Messages in this thread | | | Subject | Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control | From | Archit Taneja <> | Date | Mon, 4 Sep 2017 17:10:45 +0530 |
| |
On 09/01/2017 07:15 PM, Andrzej Hajda wrote: > On 01.08.2017 15:23, Philippe CORNU wrote: >> Based on patch "Convert drivers to explicit reset API" from Philipp Zabel >> >> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting >> reset lines") started to transition the reset control request API calls >> to explicitly state whether the driver needs exclusive or shared reset >> control behavior. Convert all drivers requesting exclusive resets to the >> explicit API call so the temporary transition helpers can be removed. >> >> No functional changes. >> >> Cc: Philipp Zabel <p.zabel@pengutronix.de> >> Signed-off-by: Philippe CORNU <philippe.cornu@st.com> >> Acked-by: Philipp Zabel <p.zabel@pengutronix.de> >> --- >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +++------- >> 1 file changed, 3 insertions(+), 7 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> index 781340d..4e1f91e 100644 >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c >> @@ -885,15 +885,11 @@ static int dw_mipi_dsi_bridge_attach(struct drm_bridge *bridge) >> * Note that the reset was not defined in the initial device tree, so >> * we have to be prepared for it not being found. >> */ >> - apb_rst = devm_reset_control_get(dev, "apb"); >> + apb_rst = devm_reset_control_get_optional_exclusive(dev, "apb"); >> if (IS_ERR(apb_rst)) { >> ret = PTR_ERR(apb_rst); >> - if (ret == -ENOENT) { >> - apb_rst = NULL; >> - } else { >> - dev_err(dev, "Unable to get reset control: %d\n", ret); >> - return ERR_PTR(ret); >> - } >> + dev_err(dev, "Unable to get reset control: %d\n", ret); > > I think in case of deferred probing it shouldn't be dev_err, but this is > rather suggestion. > >> + return ERR_PTR(ret); > > return apb_rst; > > With this fixed: > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
queued to drm-misc-next after incorporating Andrzej's comment.
> > -- > Regards > Andrzej > >> } >> >> if (apb_rst) { > >
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |