lkml.org 
[lkml]   [2017]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH][pinctrl-next] pinctrl: sprd: make three local functions static
Hi,

On 4 September 2017 at 18:53, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The functions sprd_pmx_get_function_count, sprd_pmx_get_function_name
> and sprd_pmx_get_function_groups are local to the source and do not
> need to be in global scope, so make them static.
>
> Cleans up sparse warnings:
> "symbol 'sprd_pmx_get_function_count' was not declared. Should it be
> static?"
> "symbol 'sprd_pmx_get_function_name' was not declared. Should it be
> static?"
> "symbol 'sprd_pmx_get_function_groups' was not declared. Should it be
> static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Ah, I missed these functions, thanks for fixing this issue.

> ---
> drivers/pinctrl/sprd/pinctrl-sprd.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c
> index 7e7b9ac7e836..c178b4a6d7f5 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
> @@ -353,13 +353,13 @@ static const struct pinctrl_ops sprd_pctrl_ops = {
> .dt_free_map = pinctrl_utils_free_map,
> };
>
> -int sprd_pmx_get_function_count(struct pinctrl_dev *pctldev)
> +static int sprd_pmx_get_function_count(struct pinctrl_dev *pctldev)
> {
> return PIN_FUNC_MAX;
> }
>
> -const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
> - unsigned int selector)
> +static const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
> + unsigned int selector)
> {
> switch (selector) {
> case PIN_FUNC_1:
> @@ -375,10 +375,10 @@ const char *sprd_pmx_get_function_name(struct pinctrl_dev *pctldev,
> }
> }
>
> -int sprd_pmx_get_function_groups(struct pinctrl_dev *pctldev,
> - unsigned int selector,
> - const char * const **groups,
> - unsigned int * const num_groups)
> +static int sprd_pmx_get_function_groups(struct pinctrl_dev *pctldev,
> + unsigned int selector,
> + const char * const **groups,
> + unsigned int * const num_groups)
> {
> struct sprd_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
> struct sprd_pinctrl_soc_info *info = pctl->info;
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Baolin.wang
Best Regards

\
 
 \ /
  Last update: 2017-09-04 12:58    [W:0.068 / U:3.480 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site