lkml.org 
[lkml]   [2017]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5] arm64: allwinner: h5: add support for NanoPi NEO Plus2
Hi Antony,

On Fri, Sep 01, 2017 at 12:53:13PM +0200, Antony Antony wrote:
> > > +&emac {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&emac_rgmii_pins>;
> > > + phy-supply = <&reg_gmac_3v3>;
> > > + phy-handle = <&ext_rgmii_phy>;
> > > + phy-mode = "rgmii";
> > > + status = "okay";
> > > +};
> > > +
> > > +&mdio {
> > > + ext_rgmii_phy: ethernet-phy@7 {
> > > + compatible = "ethernet-phy-ieee802.3-c22";
> > > + reg = <7>;
> > > + };
> > > +};
> >
> > This will not compile.
>
> I don't understand you, because, v5 file compiled for me. Here is output
> from running system, just the relevant part. using dtc -I fs
> /proc/device-tree
>
> ext_rgmii_phy = "/soc/ethernet@1c30000/mdio/ethernet-phy@7";
>
> ethernet@1c30000 {
> mdio {
> ..
> ethernet-phy@7 {
> compatible = "ethernet-phy-ieee802.3-c22";
> phandle = <0x1c>;
> reg = <0x7>;
> linux,phandle = <0x1c>;
> };
> };
>
> Is this what you expect?

The bindings have been reverted recently, so if you based your work on
a version between 4.13-rc1 and 4.13-rc6 it will work, but anything
more recent will not compile anymore.

> > > + status = "okay";
> > > +
> > > + /*
> > > + * AMPAK AP6212A WiFi module with BCM43430, rev=1 inside
> > > + * sdio vendor ID: 0x02d0, sdio device ID: 0xa9a6
> > > + * There is no specific Documentation: dt-binding for BCM43430
> > > + * brcm,bcm4329-fmac compatible can initialize this module
> > > + */
> >
> > This is not really relevant.
>
> would you prefer no comment or a rewrite? How does this look?
>
> /*
> * AMPAK AP6212A WiFi module with BCM43430, rev=1 inside
> * sdio vendor ID: 0x02d0, sdio device ID: 0xa9a6
> */
>
> I am afraid a casual reader would think "brcm,bcm4329-fmac" is wrong,
> because that is not the actual chip inside the module.

No comment is fine, and I'm not sure the casual reader will ever read
this :)

> > > +&mmc2_8bit_pins {
> > > + /* Increase drive strength for DDR modes */
> > > + drive-strength = <40>;
> >
> > It's very likely that you actually don't need 40mA
>
> drive-strength and the node mmc2_8bit_pins are gone. When I removed it
> drive-strength = <0x1e>; seems the default. And eMMC seems to work when
> booting from Micro SD.

Yes, we set the specs default in the DTSI. 40mA is above what the spec
requires, so not a big deal, but useless.

> NOTE: the 40mA came from a vresion of vendor's old dts file and I also
> noticed the same value is used in other dts in kernel e.g
> sun8i-h3-orangepi-plus.dts, sun9i-a80-cubieboard4.dts
> It could be a copy paste error or those boards need it. Anyway I removed it.

And we used to let that in before yes, so there might be some places
where it's left.

Feel free to clean them up if you feel bored :)

> > > +&usb_otg {
> > > + dr_mode = "host";
> > > + status = "okay";
> > > +};
> > > +
> > > +&usbphy {
> > > + /* USB Type-A ports' VBUS is always on */
> > > + usb0_id_det-gpios = <&pio 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
> >
> > If it has an ID-detect pin, then it's not a host-only USB OTG
> > controller. dr_mode should be set to otga
>
> good point. I don't see an ID-detect connected in the schematic. The
> previous generation had.
>
> I will leave
> &usb_otg {
> dr_mode = "host";
> status = "okay";
> };
>
> &usbphy {
> /* USB Type-A ports' VBUS is always on */
> status = "okay";
> };

Looking at the schematics, it seems that the micro USB isn't even
wired to a bus but is only used to power the board. If so, you can
even remove the usb_otg node.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-09-04 10:28    [W:0.073 / U:1.192 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site