Messages in this thread | | | Date | Sat, 30 Sep 2017 10:49:34 +0200 | From | Borislav Petkov <> | Subject | Re: [Part1 PATCH v5.1 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support |
| |
On Fri, Sep 29, 2017 at 04:27:47PM -0500, Brijesh Singh wrote: > From: Tom Lendacky <thomas.lendacky@amd.com> > > Provide support for Secure Encrypted Virtualization (SEV). This initial > support defines a flag that is used by the kernel to determine if it is > running with SEV active. > > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: Borislav Petkov <bp@suse.de> > Cc: Andy Lutomirski <luto@kernel.org> > Cc: linux-kernel@vger.kernel.org > Cc: x86@kernel.org > Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com> > Signed-off-by: Brijesh Singh <brijesh.singh@amd.com> > --- > > Hi Boris, > > Similar to the sme_me_mask, sev_enabled must live in .data section otherwise it > will get zero'ed in clear_bss() and we will loose the value. I have encountered > this issue when booting SEV guest using qemu's -kernel option.
Ah, good catch.
> I have removed your R-b since was not sure if you are still okay with the change.
Sure, looks good still.
Reviewed-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --
| |