Messages in this thread | | | Subject | Re: [PATCH v3 1/6] gpu: host1x: Enable Tegra186 syncpoint protection | From | Mikko Perttunen <> | Date | Sat, 30 Sep 2017 10:01:51 +0300 |
| |
On 09/30/2017 05:41 AM, Dmitry Osipenko wrote: > On 28.09.2017 15:50, Mikko Perttunen wrote: >> .. >> diff --git a/drivers/gpu/host1x/hw/channel_hw.c b/drivers/gpu/host1x/hw/channel_hw.c >> index 8447a56c41ca..b929d7f1e291 100644 >> --- a/drivers/gpu/host1x/hw/channel_hw.c >> +++ b/drivers/gpu/host1x/hw/channel_hw.c >> @@ -147,6 +147,9 @@ static int channel_submit(struct host1x_job *job) >> >> syncval = host1x_syncpt_incr_max(sp, user_syncpt_incrs); >> >> + /* assign syncpoint to channel */ >> + host1x_hw_syncpt_assign_to_channel(host, sp, ch); >> + > > Since you've preserved the comment, what about to extend it with a brief > explanation of what actually the 'assignment' does? Like that CDMA will stop > execution on touching any syncpoint other then the assigned one.
Whoops, I actually forgot to remove that :) I think the best would be to remove the comment here and have a more proper description of the feature somewhere else.
Mikko
| |