lkml.org 
[lkml]   [2017]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: Linux 4.13.4
Date
Hi 

I did things old school via patch -R. This is what I reverted:

---
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 4083be61b328..6417febe18b9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -95,9 +95,8 @@ int psp_wait_for(struct psp_context *psp, uint32_t
reg_index,
int i;
struct amdgpu_device *adev = psp->adev;

- val = RREG32(reg_index);
-
for (i = 0; i < adev->usec_timeout; i++) {
+ val = RREG32(reg_index);
if (check_changed) {
if (val != reg_val)
return 0;
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
index c98d77d0c8f8..6f80ad8f588b 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v3_1.c
@@ -237,11 +237,9 @@ int psp_v3_1_bootloader_load_sos(struct psp_context
*psp)

/* there might be handshake issue with hardware which needs delay
*/
mdelay(20);
-#if 0
ret = psp_wait_for(psp, SOC15_REG_OFFSET(MP0, 0,
mmMP0_SMN_C2PMSG_81),
RREG32_SOC15(MP0, 0, mmMP0_SMN_C2PMSG_81),
0, true);
-#endif

return ret;
}
---
Thanks
Ed

On Saturday, September 30, 2017 10:24:17 AM EDT, Greg KH wrote:
> On Sat, Sep 30, 2017 at 09:49:28AM -0400, Ed Tomlinson wrote:
>> Hi,
>>
>> This build causes very annoying flickering on my display. I
>> am using the in
>> kernel amdgpu module to drive a RX480 with 4G via display port. When X is
>> started (kde) I get flickers that are extrememly distracting. The linux
>> install is arch stable and is up to date. Nothing interesting
>> in dmesg. ...
>
> What was the git commit id that you reverted to fix the issue?
> Is the issue in 4.14-rc2?
>
> thanks,
>
> greg k-h
>
>

\
 
 \ /
  Last update: 2017-09-30 19:44    [W:0.054 / U:1.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site