Messages in this thread | | | Subject | Re: [PATCH 01/12] usb: mtu3: fix error return code in ssusb_gadget_init() | From | Sergei Shtylyov <> | Date | Sat, 30 Sep 2017 16:00:28 +0300 |
| |
Hello!
On 9/28/2017 3:17 AM, Chunfeng Yun wrote:
> When fail to get irq number, platform_get_irq() may return
Failing. IRQ. :-)
> -EPROBE_DEFER, but we ignore it and always return -ENODEV, > so fix it. > > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> > --- > drivers/usb/mtu3/mtu3_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c > index 99c65b0..9475798 100644 > --- a/drivers/usb/mtu3/mtu3_core.c > +++ b/drivers/usb/mtu3/mtu3_core.c > @@ -774,9 +774,9 @@ int ssusb_gadget_init(struct ssusb_mtk *ssusb) > return -ENOMEM; > > mtu->irq = platform_get_irq(pdev, 0); > - if (mtu->irq <= 0) { > + if (mtu->irq < 0) {
This is good as the function no longer returns 0 on error. Even when it did, 0 could mean a valid IRQ as well...
> dev_err(dev, "fail to get irq number\n"); > - return -ENODEV; > + return mtu->irq; > } > dev_info(dev, "irq %d\n", mtu->irq); >
MBR, Sergei
| |