lkml.org 
[lkml]   [2017]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V13 1/4] PCI: Don't ignore valid response before CRS timeout
On Tue, Aug 29, 2017 at 12:53 PM, Bjorn Helgaas <helgaas@kernel.org> wrote:

>
> Applied this series to pci/enumeration for v4.14. You didn't include a
> cover letter, but the series includes:
>
> [V13 1/4] PCI: Don't ignore valid response before CRS timeout
> [V13 2/4] PCI: Factor out pci_bus_wait_crs()
> [V13 3/4] PCI: Handle CRS ('device not ready') returned by device af
> [V13 4/4] PCI: Warn periodically while waiting for device to become
>
> I made some changes:
>
> - Renamed pci_bus_crs_visibility_pending() to pci_bus_crs_vendor_id()
> because the CRS completion is not "pending". It is not waiting
> somewhere for us to do something about it. The CRS completion has
> already occurred and is over. All we have now is a magic Vendor ID
> value that tells us that it happened.
>
> - Split addition of pci_bus_crs_vendor_id() to a separate patch, move
> it to probe.c, and make it static.

the calling of pci_bus_crs_vendor_id() in pci_bus_read_dev_vendor_id()
could be removed. pci_bus_wait_crs() have that calling inside.

-Yinghai

\
 
 \ /
  Last update: 2017-09-04 00:14    [W:0.081 / U:7.084 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site