lkml.org 
[lkml]   [2017]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: imu: inv_mpu6050: make arrays hz and d static
On Wed, 30 Aug 2017 12:16:16 +0100
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the arrays on the stack, instead make them static.
> Makes the object code smaller by 135 bytes:
>
> Before:
> text data bss dec hex filename
> 15135 4240 128 19503 4c2f inv_mpu_core.o
>
> After:
> text data bss dec hex filename
> 14840 4400 128 19368 4ba8 inv_mpu_core.o
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to the togreg branch of iio.git and pushed out as
testing or the autobuilders to play with it.

Thanks,

Jonathan
> ---
> drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> index 44830bce13df..6692f5e08dc8 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> @@ -570,10 +570,12 @@ static int inv_mpu6050_write_raw(struct iio_dev *indio_dev,
> */
> static int inv_mpu6050_set_lpf(struct inv_mpu6050_state *st, int rate)
> {
> - const int hz[] = {188, 98, 42, 20, 10, 5};
> - const int d[] = {INV_MPU6050_FILTER_188HZ, INV_MPU6050_FILTER_98HZ,
> - INV_MPU6050_FILTER_42HZ, INV_MPU6050_FILTER_20HZ,
> - INV_MPU6050_FILTER_10HZ, INV_MPU6050_FILTER_5HZ};
> + static const int hz[] = {188, 98, 42, 20, 10, 5};
> + static const int d[] = {
> + INV_MPU6050_FILTER_188HZ, INV_MPU6050_FILTER_98HZ,
> + INV_MPU6050_FILTER_42HZ, INV_MPU6050_FILTER_20HZ,
> + INV_MPU6050_FILTER_10HZ, INV_MPU6050_FILTER_5HZ
> + };
> int i, h, result;
> u8 data;
>

\
 
 \ /
  Last update: 2017-09-03 18:42    [W:0.034 / U:0.344 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site