lkml.org 
[lkml]   [2017]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH net-next 2/8] net: dsa: directly fetch switch in lan9303_rcv
Date
Hi Florian,

Florian Fainelli <f.fainelli@gmail.com> writes:

>> @@ -72,11 +72,10 @@ static struct sk_buff *lan9303_rcv(struct sk_buff *skb, struct net_device *dev,
>> {
>> u16 *lan9303_tag;
>> struct dsa_switch_tree *dst = dev->dsa_ptr;
>> - struct dsa_switch *ds;
>> + struct dsa_port *cpu_dp = dst->cpu_dp;
>> + struct dsa_switch *ds = cpu_dp->ds;
>> unsigned int source_port;
>>
>> - ds = dst->ds[0];
>> -
>> if (unlikely(!ds)) {
>> dev_warn_ratelimited(&dev->dev, "Dropping packet, due to missing DSA switch device\n");
>> return NULL;
>
> Similarly to the patch before, you can probably drop this test, I don't
> actually see how we could trigger it.

Good catch, I'll respin after eventually more reviews.


Thanks,

Vivien

\
 
 \ /
  Last update: 2017-09-29 21:15    [W:0.047 / U:5.468 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site