[lkml]   [2017]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH][net-next] net_sched: remove redundant assignment to ret
On Fri, Sep 29, 2017 at 7:01 AM, Colin King <> wrote:
> From: Colin Ian King <>
> The assignment of -EINVAL to variable ret is redundant as it
> is being overwritten on the following error exit paths or
> to the return value from the following call to basic_set_parms.
> Fix this up by removing it. Cleans up clang warning message:
> net/sched/cls_basic.c:185:2: warning: Value stored to 'err' is never read
> Signed-off-by: Colin Ian King <>

Fixes: 1d8134fea2eb ("net_sched: use idr to allocate basic filter handles")

Acked-by: Cong Wang <>

 \ /
  Last update: 2017-09-29 19:38    [W:0.050 / U:1.312 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site