lkml.org 
[lkml]   [2017]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/arm: Replace instances of drm_dev_unref with drm_dev_put.
Hi Srishti,

On Fri, Sep 29, 2017 at 03:30:40PM +0530, Srishti Sharma wrote:
> Replace drm_dev_unref with drm_dev_put as it is more consistent
> with kernel coding style. Done using the following semantic
> patch by coccinelle.

Thanks for the patch!

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

I'm going to pull this patch into the mali-dp tree next week when
I'm preparing an update of that tree.

Best regards,
Liviu

>
> @r@
> expression e;
> @@
>
> -drm_dev_unref();
> +drm_dev_put();
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
> drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++--
> drivers/gpu/drm/arm/malidp_drv.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/hdlcd_drv.c b/drivers/gpu/drm/arm/hdlcd_drv.c
> index f9bda7b..1a96462 100644
> --- a/drivers/gpu/drm/arm/hdlcd_drv.c
> +++ b/drivers/gpu/drm/arm/hdlcd_drv.c
> @@ -353,7 +353,7 @@ static int hdlcd_drm_bind(struct device *dev)
> err_free:
> drm_mode_config_cleanup(drm);
> dev_set_drvdata(dev, NULL);
> - drm_dev_unref(drm);
> + drm_dev_put(drm);
>
> return ret;
> }
> @@ -378,7 +378,7 @@ static void hdlcd_drm_unbind(struct device *dev)
> pm_runtime_disable(drm->dev);
> of_reserved_mem_device_release(drm->dev);
> drm_mode_config_cleanup(drm);
> - drm_dev_unref(drm);
> + drm_dev_put(drm);
> drm->dev_private = NULL;
> dev_set_drvdata(dev, NULL);
> }
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 7ae94a1..1b92f41 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -665,7 +665,7 @@ static int malidp_bind(struct device *dev)
> malidp_runtime_pm_suspend(dev);
> drm->dev_private = NULL;
> dev_set_drvdata(dev, NULL);
> - drm_dev_unref(drm);
> + drm_dev_put(drm);
> alloc_fail:
> of_reserved_mem_device_release(dev);
>
> @@ -698,7 +698,7 @@ static void malidp_unbind(struct device *dev)
> malidp_runtime_pm_suspend(dev);
> drm->dev_private = NULL;
> dev_set_drvdata(dev, NULL);
> - drm_dev_unref(drm);
> + drm_dev_put(drm);
> of_reserved_mem_device_release(dev);
> }
>
> --
> 2.7.4
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯

\
 
 \ /
  Last update: 2017-09-29 17:26    [W:0.034 / U:5.432 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site