This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Wed Apr 24 13:32:44 2024 >From mailfetcher Fri Sep 29 16:49:23 2017 Envelope-to: lkml@grols.ch Delivery-date: Fri, 29 Sep 2017 16:49:23 +0200 Received: from srv.grols.ch [5.172.41.101] by 74f7beb50cb2 with IMAP (fetchmail-6.3.26) for (single-drop); Fri, 29 Sep 2017 16:49:23 +0200 (CEST) Received: from vger.kernel.org ([209.132.180.67]) by home.grols.ch with esmtp (Exim 4.89) (envelope-from ) id 1dxwbS-0004FC-Ni for lkml@grols.ch; Fri, 29 Sep 2017 16:49:23 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752231AbdI2Osy (ORCPT ); Fri, 29 Sep 2017 10:48:54 -0400 Received: from mga02.intel.com ([134.134.136.20]:22173 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbdI2Ose (ORCPT ); Fri, 29 Sep 2017 10:48:34 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2017 07:48:33 -0700 X-ExtLoop1: 1 X-Ironport-AV: E=Sophos;i="5.42,452,1500966000"; d="scan'208";a="905126992" Received: from otc-knm-01.jf.intel.com ([10.54.39.34]) by FMSMGA003.fm.intel.com with ESMTP; 29 Sep 2017 07:48:33 -0700 From: kan.liang@intel.com To: acme@kernel.org, peterz@infradead.org, mingo@redhat.com, linux-kernel@vger.kernel.org Cc: jolsa@kernel.org, namhyung@kernel.org, adrian.hunter@intel.com, lukasz.odzioba@intel.com, wangnan0@huawei.com, hekuang@huawei.com, ast@kernel.org, ak@linux.intel.com, Kan Liang Subject: [PATCH RFC V4 4/6] perf top: add option to set the number of thread for event synthesize Date: Fri, 29 Sep 2017 07:47:55 -0700 Message-Id: <1506696477-146932-5-git-send-email-kan.liang@intel.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1506696477-146932-1-git-send-email-kan.liang@intel.com> References: <1506696477-146932-1-git-send-email-kan.liang@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org Received-SPF: none client-ip=209.132.180.67; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org X-Spam-Score: 5.7 X-Spam-Score-Bar: +++++ X-Spam-Action: greylist X-Spam-Report: Action: greylist Symbol: R_SPF_NA(0.00) Symbol: RCPT_COUNT_TWELVE(0.00) Symbol: MAILLIST(-0.20) Symbol: ASN(0.00) Symbol: MIME_GOOD(-0.10) Symbol: TO_DN_SOME(0.00) Symbol: BAYES_SPAM(4.00) Symbol: FROM_NO_DN(0.00) Symbol: RCVD_COUNT_FIVE(0.00) Symbol: PR From: Kan Liang Using UINT_MAX to indicate the default thread#, which is the max number of online CPU. Signed-off-by: Kan Liang --- tools/perf/Documentation/perf-top.txt | 3 +++ tools/perf/builtin-top.c | 11 ++++++++--- tools/perf/util/event.c | 5 ++++- tools/perf/util/top.h | 1 + 4 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt index d864ea6..c3cc9a3 100644 --- a/tools/perf/Documentation/perf-top.txt +++ b/tools/perf/Documentation/perf-top.txt @@ -240,6 +240,9 @@ Default is to monitor all CPUS. --force:: Don't do ownership validation. +--num-thread-synthesize:: + The number of threads to run event synthesize. + By default, the number of threads equals to the online CPU number. INTERACTIVE PROMPTING KEYS -------------------------- diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index bc31b93..477a869 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -958,14 +958,16 @@ static int __cmd_top(struct perf_top *top) if (perf_session__register_idle_thread(top->session) < 0) goto out_delete; - perf_set_multithreaded(); + if (top->nr_threads_synthesize > 1) + perf_set_multithreaded(); machine__synthesize_threads(&top->session->machines.host, &opts->target, top->evlist->threads, false, opts->proc_map_timeout, - (unsigned int)sysconf(_SC_NPROCESSORS_ONLN)); + top->nr_threads_synthesize); - perf_set_singlethreaded(); + if (top->nr_threads_synthesize > 1) + perf_set_singlethreaded(); if (perf_hpp_list.socket) { ret = perf_env__read_cpu_topology_map(&perf_env); @@ -1118,6 +1120,7 @@ int cmd_top(int argc, const char **argv) }, .max_stack = sysctl_perf_event_max_stack, .sym_pcnt_filter = 5, + .nr_threads_synthesize = UINT_MAX, }; struct record_opts *opts = &top.record_opts; struct target *target = &opts->target; @@ -1227,6 +1230,8 @@ int cmd_top(int argc, const char **argv) OPT_BOOLEAN(0, "hierarchy", &symbol_conf.report_hierarchy, "Show entries in a hierarchy"), OPT_BOOLEAN(0, "force", &symbol_conf.force, "don't complain, do it"), + OPT_UINTEGER(0, "num-thread-synthesize", &top.nr_threads_synthesize, + "number of thread to run event synthesize"), OPT_END() }; const char * const top_usage[] = { diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c index 0e678dd..47eff47 100644 --- a/tools/perf/util/event.c +++ b/tools/perf/util/event.c @@ -790,7 +790,10 @@ int perf_event__synthesize_threads(struct perf_tool *tool, if (n < 0) return err; - thread_nr = nr_threads_synthesize; + if (nr_threads_synthesize == UINT_MAX) + thread_nr = sysconf(_SC_NPROCESSORS_ONLN); + else + thread_nr = nr_threads_synthesize; if (thread_nr <= 1) { err = __perf_event__synthesize_threads(tool, process, diff --git a/tools/perf/util/top.h b/tools/perf/util/top.h index 9bdfb78..f4296e1 100644 --- a/tools/perf/util/top.h +++ b/tools/perf/util/top.h @@ -37,6 +37,7 @@ struct perf_top { int sym_pcnt_filter; const char *sym_filter; float min_percent; + unsigned int nr_threads_synthesize; }; #define CONSOLE_CLEAR "" -- 2.5.5