lkml.org 
[lkml]   [2017]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v2 03/18] sched/fair: Cure calc_cfs_shares() vs reweight_entity()
On Fri, Sep 29, 2017 at 01:38:53PM +0200, Peter Zijlstra wrote:
> On Fri, Sep 29, 2017 at 10:04:34AM +0100, Morten Rasmussen wrote:
>
> > > - load = scale_load_down(cfs_rq->load.weight);
> > > + load = max(scale_load_down(cfs_rq->load.weight), cfs_rq->avg.load_avg);
> >
> > We use cfs_rq->tg_load_avg_contrib (the filtered version of
> > cfs_rq->avg.load_avg) instead of cfs_rq->avg.load_avg further down, so I
> > think we should here too for consistency.
> >
> > + load = max(scale_load_down(cfs_rq->load.weight),
> > + cfs_rq->tg_load_avg_contrib);
> >
>
> No; we must use tg_load_avg_contrib because that is what's inclded in
> tg_weight, but we want to add the most up-to-date value back in.

Agreed. Looking at it again it make sense.

\
 
 \ /
  Last update: 2017-09-29 15:06    [W:0.295 / U:0.264 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site