Messages in this thread | | | Subject | Re: [PATCH][ipmi-next] ipmi: remove redundant initialization of bmc | From | Corey Minyard <> | Date | Thu, 28 Sep 2017 12:31:23 -0500 |
| |
On 09/28/2017 08:22 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The pointer bmc is being initialized and this initialized value is > never being read, so this is assignment redundant and can be removed. > Cleans up clang warning: > > warning: Value stored to 'bmc' during its initialization is never read
yes, obviously unneeded. Queued.
Thanks,
-corey
> Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/char/ipmi/ipmi_msghandler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c > index c29d46bef6b3..9de189db2cc3 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -2941,7 +2941,7 @@ static int __ipmi_bmc_register(ipmi_smi_t intf, > bool guid_set, guid_t *guid, int intf_num) > { > int rv; > - struct bmc_device *bmc = intf->bmc; > + struct bmc_device *bmc; > struct bmc_device *old_bmc; > > /*
| |