lkml.org 
[lkml]   [2017]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][ipmi-next] ipmi: remove redundant initialization of bmc
From
Date
On 09/28/2017 08:22 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer bmc is being initialized and this initialized value is
> never being read, so this is assignment redundant and can be removed.
> Cleans up clang warning:
>
> warning: Value stored to 'bmc' during its initialization is never read

yes, obviously unneeded.  Queued.

Thanks,

-corey

> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index c29d46bef6b3..9de189db2cc3 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -2941,7 +2941,7 @@ static int __ipmi_bmc_register(ipmi_smi_t intf,
> bool guid_set, guid_t *guid, int intf_num)
> {
> int rv;
> - struct bmc_device *bmc = intf->bmc;
> + struct bmc_device *bmc;
> struct bmc_device *old_bmc;
>
> /*


\
 
 \ /
  Last update: 2017-09-28 19:32    [W:0.066 / U:10.072 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site