lkml.org 
[lkml]   [2017]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH V3] r8152: add Linksys USB3GIGV1 id
Hi,

On Wed, Sep 27, 2017 at 5:07 PM, Grant Grundler <grundler@chromium.org> wrote:
>>> #define DELL_VENDOR_ID 0x413C
>>> #define REALTEK_VENDOR_ID 0x0bda
>>> #define SAMSUNG_VENDOR_ID 0x04e8
>>> +#define LINKSYS_VENDOR_ID 0x13b1
>>> #define LENOVO_VENDOR_ID 0x17ef
>>
>> Slight nit that "LI" sorts after "LE". You got it right in the other case...
>
> The list isn't sorted by any rational thing I can see. I managed to
> check my OCD reaction to sort the list numerically. :)

Whoops, you're right. It seems to be in a random order. I just saw
LE, LI, and N sorted properly and jumped to a conclusion. In any
case, if it's all the same to you it'd be nice if you were consistent
between LENOVO/LINKSYS in the two files. :-P

-Doug

\
 
 \ /
  Last update: 2017-09-28 17:12    [W:0.050 / U:5.000 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site