Messages in this thread | | | Date | Thu, 28 Sep 2017 07:53:02 -0700 | From | Tejun Heo <> | Subject | Re: EBPF-triggered WARNING at mm/percpu.c:1361 in v4-14-rc2 |
| |
Hello,
On Thu, Sep 28, 2017 at 03:45:38PM +0100, Mark Rutland wrote: > > Perhaps the pr_warn() should be ratelimited; or could there be an > > option where we only return NULL, not triggering a warn at all (which > > would likely be what callers might do anyway when checking against > > PCPU_MIN_UNIT_SIZE and then bailing out)? > > Those both make sense to me; checking __GFP_NOWARN should be easy > enough.
That also makes sense.
> Just to check, do you think that dev_map_alloc() should explicitly test > the size against PCPU_MIN_UNIT_SIZE, prior to calling pcpu_alloc()?
But let's please not do this.
Thanks.
-- tejun
| |