lkml.org 
[lkml]   [2017]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] irq/generic-chip: Don't replace domain's name
Date
Currently we are replacing domain's name with irq chip's name when
allocating generic chips.

When the old domain's name is allocated, it would cause memory leak.
Even worse the domain framework would try to free the wrong name later.

Fixes: d59f6617eef0 ("genirq: Allow fwnode to carry name information only")
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---

Changes in v2:
Don't replace domain's name instead of trying to free the old name.

kernel/irq/generic-chip.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c
index f7086b78ad6e..5270a54b9fa4 100644
--- a/kernel/irq/generic-chip.c
+++ b/kernel/irq/generic-chip.c
@@ -322,7 +322,6 @@ int __irq_alloc_domain_generic_chips(struct irq_domain *d, int irqs_per_chip,
/* Calc pointer to the next generic chip */
tmp += sizeof(*gc) + num_ct * sizeof(struct irq_chip_type);
}
- d->name = name;
return 0;
}
EXPORT_SYMBOL_GPL(__irq_alloc_domain_generic_chips);
--
2.11.0

\
 
 \ /
  Last update: 2017-09-28 06:37    [W:0.054 / U:3.672 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site