Messages in this thread | | | Subject | Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel panic | From | "Yang Shi" <> | Date | Thu, 28 Sep 2017 06:11:46 +0800 |
| |
On 9/27/17 2:59 PM, Christopher Lameter wrote: > On Thu, 28 Sep 2017, Yang Shi wrote: >>> CONFIG_SLABINFO? How does this relate to the oom info? /proc/slabinfo >>> support is optional. Oom info could be included even if CONFIG_SLABINFO >>> goes away. Remove the #ifdef? >> >> Because we want to dump the unreclaimable slab info in oom info. > > CONFIG_SLABINFO and /proc/slabinfo have nothing to do with the > unreclaimable slab info.
The current design uses "struct slabinfo" and get_slabinfo() to retrieve some info, i.e. active objs, etc. They are protected by CONFIG_SLABINFO.
We could replicate the logic in get_slabinfo without using struct slabinfo, but it sounds not that necessary and CONFIG_SLABINFO is typically enabled by default and it is not shown in menuconfig.
Thanks, Yang
>
| |