Messages in this thread | | | Subject | Wrong -dirty suffix set by setlocalversion (was: BUG in git diff-index) | From | Marc Herbert <> | Date | Wed, 27 Sep 2017 14:06:24 -0700 |
| |
+ linux-kbuild list which is not in the output of: ./scripts/get_maintainer.pl -f scripts/setlocalversion ... but seems relevant anyway.
On 31/03/16 13:39, Junio C Hamano wrote: > Andy Lowry <andy.work@nglowry.com> writes: > >> So I think now that the script should do "update-index --refresh" >> followed by "diff-index --quiet HEAD". Sound correct? > > Yes. That has always been one of the kosher ways for any script to > make sure that the files in the working tree that are tracked have > not been modified relative to HEAD (assuming that the index matches > HEAD).
Too bad kernel/scripts/setlocalversion didn't get the memo:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cdf2bc632ebc9ef51 > scripts/setlocalversion on write-protected source tree (2013) > I don't see how removing "git update-index" could do any harm.
This causes a spurious "-dirty" suffix when building from a directory copy (as Mike learned the hard way)
[...]
https://public-inbox.org/git/1459432667.2124.2.camel@dwim.me
| |