lkml.org 
[lkml]   [2017]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: update comments for struct page.mapping
On Tue, Sep 26, 2017 at 04:30:27PM -0700, Andrew Morton wrote:
> On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote:
>
> > From: Changbin Du <changbin.du@intel.com>
> >
> > The struct page.mapping can NULL or points to one object of type
> > address_space, anon_vma or KSM private structure.
> >
> > ...
> >
> > --- a/include/linux/mm_types.h
> > +++ b/include/linux/mm_types.h
> > @@ -47,8 +47,8 @@ struct page {
> > * inode address_space, or NULL.
> > * If page mapped as anonymous
> > * memory, low bit is set, and
> > - * it points to anon_vma object:
> > - * see PAGE_MAPPING_ANON below.
> > + * it points to anon_vma object
> > + * or KSM private structure.
> > */
> > void *s_mem; /* slab first object */
> > atomic_t compound_mapcount; /* first tail page */
>
> Why did you remove the (useful) reference to PAGE_MAPPING_ANON?

There are two flags now, let me add them back. thanks.

--
Thanks,
Changbin Du
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-09-27 06:06    [W:0.470 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site