lkml.org 
[lkml]   [2017]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PM / PCI: Do not resume any devices in pci_pm_prepare()
On Mon, Sep 25, 2017 at 01:33:13AM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> It should not be necessary to resume devices with ignore_children set
> in pci_pm_prepare(), because they should be resumed explcitly by
> their children drivers during suspend if need be and they will be
> resumed by pci_pm_suspend() after that anyway, so avoid doing that.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Oh, and I meant to also say that you've merged the PM-related things
here in the past, so I assume you'll take this one :)

> ---
> drivers/pci/pci-driver.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> Index: linux-pm/drivers/pci/pci-driver.c
> ===================================================================
> --- linux-pm.orig/drivers/pci/pci-driver.c
> +++ linux-pm/drivers/pci/pci-driver.c
> @@ -680,13 +680,6 @@ static int pci_pm_prepare(struct device
> {
> struct device_driver *drv = dev->driver;
>
> - /*
> - * Devices having power.ignore_children set may still be necessary for
> - * suspending their children in the next phase of device suspend.
> - */
> - if (dev->power.ignore_children)
> - pm_runtime_resume(dev);
> -
> if (drv && drv->pm && drv->pm->prepare) {
> int error = drv->pm->prepare(dev);
> if (error)
>

\
 
 \ /
  Last update: 2017-09-26 23:38    [W:0.046 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site