Messages in this thread Patch in this message | | | Subject | [PATCH 2/6] [media] tda8261: Improve a size determination in tda8261_attach() | From | SF Markus Elfring <> | Date | Tue, 26 Sep 2017 13:28:51 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 26 Sep 2017 12:06:19 +0200
* The script "checkpatch.pl" pointed information out like the following.
ERROR: do not use assignment in if condition
Thus fix an affected source code place.
* Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/dvb-frontends/tda8261.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/tda8261.c b/drivers/media/dvb-frontends/tda8261.c index 5a8a9b6b8107..5269a170c84e 100644 --- a/drivers/media/dvb-frontends/tda8261.c +++ b/drivers/media/dvb-frontends/tda8261.c @@ -185,7 +185,8 @@ struct dvb_frontend *tda8261_attach(struct dvb_frontend *fe, { struct tda8261_state *state = NULL; - if ((state = kzalloc(sizeof (struct tda8261_state), GFP_KERNEL)) == NULL) + state = kzalloc(sizeof(*state), GFP_KERNEL); + if (!state) goto exit; state->config = config; -- 2.14.1
| |