lkml.org 
[lkml]   [2017]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH review for 3.18 03/14] irqchip/crossbar: Fix incorrect type of local variables
    Date
    From: Franck Demathieu <fdemathieu@gmail.com>

    [ Upstream commit b28ace12661fbcfd90959c1e84ff5a85113a82a1 ]

    The max and entry variables are unsigned according to the dt-bindings.
    Fix following 3 sparse issues (-Wtypesign):

    drivers/irqchip/irq-crossbar.c:222:52: warning: incorrect type in argument 3 (different signedness)
    drivers/irqchip/irq-crossbar.c:222:52: expected unsigned int [usertype] *out_value
    drivers/irqchip/irq-crossbar.c:222:52: got int *<noident>

    drivers/irqchip/irq-crossbar.c:245:56: warning: incorrect type in argument 4 (different signedness)
    drivers/irqchip/irq-crossbar.c:245:56: expected unsigned int [usertype] *out_value
    drivers/irqchip/irq-crossbar.c:245:56: got int *<noident>

    drivers/irqchip/irq-crossbar.c:263:56: warning: incorrect type in argument 4 (different signedness)
    drivers/irqchip/irq-crossbar.c:263:56: expected unsigned int [usertype] *out_value
    drivers/irqchip/irq-crossbar.c:263:56: got int *<noident>

    Signed-off-by: Franck Demathieu <fdemathieu@gmail.com>
    Cc: marc.zyngier@arm.com
    Cc: jason@lakedaemon.net
    Link: http://lkml.kernel.org/r/20170223094855.6546-1-fdemathieu@gmail.com
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
    ---
    drivers/irqchip/irq-crossbar.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
    index bbbaf5de65d2..c03773bf02c7 100644
    --- a/drivers/irqchip/irq-crossbar.c
    +++ b/drivers/irqchip/irq-crossbar.c
    @@ -175,7 +175,8 @@ static const struct irq_domain_ops routable_irq_domain_ops = {

    static int __init crossbar_of_init(struct device_node *node)
    {
    - int i, size, max = 0, reserved = 0, entry;
    + int i, size, reserved = 0;
    + u32 max = 0, entry;
    const __be32 *irqsr;
    int ret = -ENOMEM;

    --
    2.11.0
    \
     
     \ /
      Last update: 2017-09-25 03:16    [W:5.713 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site