| Subject | Re: [PATCH v4 10/13] xen/pvcalls: implement recvmsg | From | Boris Ostrovsky <> | Date | Fri, 22 Sep 2017 18:05:00 -0400 |
| |
> > +static bool pvcalls_front_read_todo(struct sock_mapping *map) > +{ > + struct pvcalls_data_intf *intf = map->active.ring; > + RING_IDX cons, prod; > + int32_t error; > + > + cons = intf->in_cons; > + prod = intf->in_prod; > + error = intf->in_error; > + return (error != 0 || > + pvcalls_queued(prod, cons, > + XEN_FLEX_RING_SIZE(PVCALLS_RING_ORDER)) != 0);
Does this routine have to be different from pvcalls_front_write_todo()? They look pretty similar. Can they be merged?
(and you don't really need 'error' variable)
-boris
|