lkml.org 
[lkml]   [2017]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] pci/layerscape: change the default error response behavior
    Date
    From: Minghuan Lian <Minghuan.Lian@nxp.com>

    By default, when the PCIe controller experiences an erroneous
    completion from an external completer for its outbound non-posted
    request, it always sends an OKAY response to the device's internal
    AXI slave system interface. However, such default system error
    response behavior cannot be used for other types of outbound
    non-posted requests. For example, the outbound memory read
    transaction requires an actual ERROR response, like UR completion
    or completion timeout. The patch is to fix it by forwarding
    the error response of the non-posted request.

    Signed-off-by: Minghuan Lian <Minghuan.Lian@nxp.com>
    Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
    ---
    drivers/pci/dwc/pci-layerscape.c | 25 +++++++++++++++++++++++++
    1 file changed, 25 insertions(+)

    diff --git a/drivers/pci/dwc/pci-layerscape.c b/drivers/pci/dwc/pci-layerscape.c
    index 3b01e309a55e..a647090c140e 100644
    --- a/drivers/pci/dwc/pci-layerscape.c
    +++ b/drivers/pci/dwc/pci-layerscape.c
    @@ -33,6 +33,8 @@

    /* PEX Internal Configuration Registers */
    #define PCIE_STRFMR1 0x71c /* Symbol Timer & Filter Mask Register1 */
    +#define PCIE_ABSERR 0x8d0 /* Bridge Slave Error Response Register */
    +#define PCIE_ABSERR_SETTING 0x9401 /* Forward error of non-posted request */

    #define PCIE_IATU_NUM 6

    @@ -54,6 +56,19 @@ struct ls_pcie {

    #define to_ls_pcie(x) dev_get_drvdata((x)->dev)

    +static int err_response_flag = 1;
    +
    +static int __init ls_pcie_param(char *p)
    +{
    + if (p && strncmp(p, "no-err-response", 15) == 0)
    + err_response_flag = 0;
    + else
    + err_response_flag = 1;
    +
    + return 0;
    +}
    +early_param("ls_pcie", ls_pcie_param);
    +
    static bool ls_pcie_is_bridge(struct ls_pcie *pcie)
    {
    struct dw_pcie *pci = pcie->pci;
    @@ -124,6 +139,14 @@ static int ls_pcie_link_up(struct dw_pcie *pci)
    return 1;
    }

    +/* Forward error response of outbound non-posted requests */
    +static void ls_pcie_fix_error_response(struct ls_pcie *pcie)
    +{
    + struct dw_pcie *pci = pcie->pci;
    +
    + iowrite32(PCIE_ABSERR_SETTING, pci->dbi_base + PCIE_ABSERR);
    +}
    +
    static int ls_pcie_host_init(struct pcie_port *pp)
    {
    struct dw_pcie *pci = to_dw_pcie_from_pp(pp);
    @@ -135,6 +158,8 @@ static int ls_pcie_host_init(struct pcie_port *pp)
    * dw_pcie_setup_rc() will reconfigure the outbound windows.
    */
    ls_pcie_disable_outbound_atus(pcie);
    + if (err_response_flag)
    + ls_pcie_fix_error_response(pcie);

    dw_pcie_dbi_ro_wr_en(pci);
    ls_pcie_clear_multifunction(pcie);
    --
    2.14.1
    \
     
     \ /
      Last update: 2017-09-22 09:44    [W:3.455 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site