lkml.org 
[lkml]   [2017]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/6] lightnvm: pblk: improve error message if down_timeout fails
Date
> On 21 Sep 2017, at 13.27, Rakesh Pandit <rakesh@tuxera.com> wrote:
>
> The two pr_err messages are useless as they don't even differentiate
> error code.
>
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
> drivers/lightnvm/pblk-core.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index b92eabc..74ddb30 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1734,16 +1734,8 @@ static void __pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list,
> #endif
>
> ret = down_timeout(&rlun->wr_sem, msecs_to_jiffies(30000));
> - if (ret) {
> - switch (ret) {
> - case -ETIME:
> - pr_err("pblk: lun semaphore timed out\n");
> - break;
> - case -EINTR:
> - pr_err("pblk: lun semaphore timed out\n");
> - break;
> - }
> - }
> + if (ret == -ETIME || ret == -EINTR)
> + pr_err("pblk: taking lun semaphore timed out: err %d\n", -ret);
> }
>
> void pblk_down_page(struct pblk *pblk, struct ppa_addr *ppa_list, int nr_ppas)
> --
> 2.5.0

Looks good.


Reviewed-by: Javier González <javier@cnexlabs.com>

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-09-22 10:55    [W:0.243 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site