lkml.org 
[lkml]   [2017]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging:rtl8188eu Remove unnecessary {} braces in
On Thu, Sep 21, 2017 at 12:18:04PM +0530, Janani Sankara Babu wrote:
> --- a/drivers/staging/rtl8188eu/hal/phy.c
> +++ b/drivers/staging/rtl8188eu/hal/phy.c
> @@ -728,9 +728,9 @@ static void patha_fill_iqk(struct adapter *adapt, bool iqkok, s32 result[][8],
> u32 oldval_0, x, tx0_a, reg;
> s32 y, tx0_c;
>
> - if (final_candidate == 0xFF) {
> + if (final_candidate == 0xFF)
> return;
> - } else if (iqkok) {
> + else if (iqkok) {

No. These ones stay. Your change would introduce a new checkpatch.pl
warning if you ran it against the patched file. The rule here is that
if one side of the if else has curly braces then both sides get them.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-09-21 19:28    [W:0.033 / U:1.552 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site