lkml.org 
[lkml]   [2017]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] block: drop "sending ioctl to a partition" message
From
Date
On 21/09/2017 16:53, Christoph Hellwig wrote:
> This looks ok to me, but do we even need to keep the special
> cases above? Is there anything relying on the safe but not very
> useful ioctls?

No idea, I stuck to the usual "don't break userspace" rule.

Honestly I doubt anything is using most of those ioctls _in general_,
not just on a partition.

Paolo

> Condensing the thing down to:
>
> int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd)
> {
> if (bd && bd == bd->bd_contains)
> return 0;
> if (capable(CAP_SYS_RAWIO))
> return 0;
> return -ENOIOCTLCMD;
> }
>
> would certainly be nice.

\
 
 \ /
  Last update: 2017-09-21 19:34    [W:0.043 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site