lkml.org 
[lkml]   [2017]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] media: staging: greybus: Release memory obtained by kasprintf
Date
Free memory region, if gb_lights_channel_config is not successful.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/staging/greybus/light.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index 3f4148c..b00d47c 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -984,7 +984,7 @@ static int gb_lights_channel_config(struct gb_light *light,

ret = channel_attr_groups_set(channel, cdev);
if (ret < 0)
- return ret;
+ goto err;

gb_lights_led_operations_set(channel, cdev);

@@ -994,15 +994,18 @@ static int gb_lights_channel_config(struct gb_light *light,
* configurations.
*/
if (!is_channel_flash(channel))
- return ret;
+ goto err;

light->has_flash = true;

ret = gb_lights_channel_flash_config(channel);
if (ret < 0)
- return ret;
+ goto err;

return ret;
+err:
+ kfree(cdev->name);
+ return ret;
}

static int gb_lights_light_config(struct gb_lights *glights, u8 id)
--
1.9.1
\
 
 \ /
  Last update: 2017-09-21 19:30    [W:0.037 / U:0.736 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site