lkml.org 
[lkml]   [2017]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] lightnvm: remove already calculated nr_chnls
From
Date
On 09/18/2017 12:56 PM, Matias Bjørling wrote:
>
>
> Den 18. sep. 2017 09.56 skrev "Javier González" <jg@lightnvm.io
> <mailto:jg@lightnvm.io>>:
>
> > On 17 Sep 2017, at 23.04, Rakesh Pandit <rakesh@tuxera.com
> <mailto:rakesh@tuxera.com>> wrote:
> >
> > Remove repeated calculation for number of channels while creating a
> > target device.
> >
> > Signed-off-by: Rakesh Pandit <rakesh@tuxera.com
> <mailto:rakesh@tuxera.com>>
> > ---
> >
> > This is also a trivial change I found while investigating/working on
> > other issue.
> >
> > drivers/lightnvm/core.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> > index 1b8338d..01536b8 100644
> > --- a/drivers/lightnvm/core.c
> > +++ b/drivers/lightnvm/core.c
> > @@ -139,7 +139,6 @@ static struct nvm_tgt_dev
> *nvm_create_tgt_dev(struct nvm_dev *dev,
> > int prev_nr_luns;
> > int i, j;
> >
> > - nr_chnls = nr_luns / dev->geo.luns_per_chnl;
> > nr_chnls = (nr_chnls_mod == 0) ? nr_chnls : nr_chnls + 1;
> >
> > dev_map = kmalloc(sizeof(struct nvm_dev_map), GFP_KERNEL);
> > --
> > 2.7.4
>
> We wanted to make sure that nr_chnls was really, really set :)
>
> Reviewed-by: Javier González <javier@cnexlabs.com
> <mailto:javier@cnexlabs.com>>
>
> What the hell... must have been a patch or merge that went wrong.

Thanks Rakesh. I pulled it in for 4.15.

\
 
 \ /
  Last update: 2017-09-21 19:30    [W:0.044 / U:1.352 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site