lkml.org 
[lkml]   [2017]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only"
    Date
    On powerpc, RODATA_TEST fails with message the following messages:

    [ 6.199505] Freeing unused kernel memory: 528K
    [ 6.203935] rodata_test: test data was not read only

    This is because GCC allocates it to .data section:

    c0695034 g O .data 00000004 rodata_test_data

    Since commit 056b9d8a76924 ("mm: remove rodata_test_data export,
    add pr_fmt"), rodata_test_data is used only inside rodata_test.c
    By declaring it static, it gets properly allocated into .rodata
    section instead of .data:

    c04df710 l O .rodata 00000004 rodata_test_data

    Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
    ---
    mm/rodata_test.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/mm/rodata_test.c b/mm/rodata_test.c
    index 6bb4deb12e78..d908c8769b48 100644
    --- a/mm/rodata_test.c
    +++ b/mm/rodata_test.c
    @@ -14,7 +14,7 @@
    #include <linux/uaccess.h>
    #include <asm/sections.h>

    -const int rodata_test_data = 0xC3;
    +static const int rodata_test_data = 0xC3;

    void rodata_test(void)
    {
    --
    2.13.3
    \
     
     \ /
      Last update: 2017-09-21 19:29    [W:2.539 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site