lkml.org 
[lkml]   [2017]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer interface
On Wed, Sep 20, 2017 at 03:52:57PM -0500, Rob Herring <robh@kernel.org> wrote:
> On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote:
> > The driver used to be developed with legacy GPIO API support. It's
> > better to use descriptor-based interface for several reasons. First
> > of all the legacy API doesn't support the ACTIVE_LOW/HIGH flag of dts
> > nodes, which is essential since different hardware may have different
> > GPIOs connectivity including the logical value inversion. Secondly,
> > by requesting the reset GPIO descriptor the driver prevent the other
> > applications from changing its value. And last but not least the
> > legacy GPIO interface should be avoided in the new code due to it
> > obsolescence.
>
> All this has nothing to do with the binding. Please make the binding
> change separate and state why it should be optional.
>

Ok.

> >
> > Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> > ---
> > Documentation/devicetree/bindings/usb/usb251xb.txt | 2 +-
> > drivers/usb/misc/usb251xb.c | 34 +++++++++-------------
> > 2 files changed, 15 insertions(+), 21 deletions(-)

\
 
 \ /
  Last update: 2017-09-21 19:24    [W:0.094 / U:10.808 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site