Messages in this thread | | | Subject | Re: [PATCH] [media] staging: atomisp: use clock framework for camera clocks | From | Andy Shevchenko <> | Date | Wed, 20 Sep 2017 22:29:26 +0300 |
| |
On Wed, 2017-09-20 at 12:01 -0500, Pierre-Louis Bossart wrote: > > On 09/20/2017 04:12 AM, Andy Shevchenko wrote: > > On Tue, 2017-09-19 at 15:45 -0500, Pierre-Louis Bossart wrote: > > > The Atom ISP driver initializes and configures PMC clocks which > > > are > > > already handled by the clock framework. > > > > > > Remove all legacy vlv2_platform_clock stuff and move to the clk > > > API to > > > avoid conflicts, e.g. with audio machine drivers enabling the MCLK > > > for > > > external codecs > > > > > > > I think it might have a Fixes: tag as well (though I dunno which > > commit > > could be considered as anchor). > > The initial integration of the atomisp driver already had this > problem, > i'll add a reference to > 'a49d25364dfb9 ("staging/atomisp: Add support for the Intel IPU v2")'
...which seems to be the best choice (you can check how many new commits use that one as an origin for Fixes: tag).
> > > > (I doubt Git is so clever to remove files based on information out > > of > > the diff, can you check it and if needed to resend without -D > > implied?) > > Gee, I thought -C -M -D were the standard options to checkpatch, > never > realized it'd prevent patches from applying. Thanks for the tip.
-C -M — yes for sure.
Last time I checked patches, generated with help of -D, do not remove the files when you do git am. So, I don't know if it still the case. Safe option is to use -C -M for public (+ -D locally only to see less noise).
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |