lkml.org 
[lkml]   [2017]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/urgent] x86/mm/32: Load a sane CR3 before cpu_init() on secondary CPUs
On Sun 2017-09-17 11:19:53, tip-bot for Andy Lutomirski wrote:
> Commit-ID: 4ba55e65f471d011d3ba2ac2022180ea0877d68e
> Gitweb: http://git.kernel.org/tip/4ba55e65f471d011d3ba2ac2022180ea0877d68e
> Author: Andy Lutomirski <luto@kernel.org>
> AuthorDate: Sun, 17 Sep 2017 09:03:51 -0700
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Sun, 17 Sep 2017 18:59:09 +0200
>
> x86/mm/32: Load a sane CR3 before cpu_init() on secondary CPUs
>
> For unknown historical reasons (i.e. Borislav doesn't recall),
> 32-bit kernels invoke cpu_init() on secondary CPUs with
> initial_page_table loaded into CR3. Then they set
> current->active_mm to &init_mm and call enter_lazy_tlb() before
> fixing CR3. This means that the x86 TLB code gets invoked while CR3
> is inconsistent, and, with the improved PCID sanity checks I added,
> we warn.
>
> Fix it by loading swapper_pg_dir (i.e. init_mm.pgd) earlier.
>
> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Reported-by: Pavel Machek <pavel@ucw.cz>

4.14.0-rc1-next-20170919 does not produce the warning during bootup.

Pavel

Tested-by: Pavel Machek <pavel@ucw.cz>


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-09-20 14:53    [W:0.047 / U:5.212 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site