Messages in this thread | | | From | Joel Stanley <> | Date | Wed, 20 Sep 2017 15:37:13 +0930 | Subject | Re: [PATCH v2 1/4] watchdog: aspeed: Retain watchdog enabled state |
| |
On Wed, Sep 20, 2017 at 3:00 PM, Andrew Jeffery <andrew@aj.id.au> wrote: > An unintended post-condition of probe() is that the watchdog is > disabled. This behaviour was introduced by an unnecessary write to the > control register to configure the hardware based on the devicetree. The > write is unnecessary because the cached control value that is > manipulated by the code parsing the devicetree is eventually written by > aspeed_wdt_enable(), which is when we care how the control register > should be configured. > > Remove the write to restore expected behaviour. > > Fixes: b7f0b8ad25f3 ("drivers/watchdog: ASPEED reference dev tree properties for config") > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Thanks,
Joel
| |