Messages in this thread | | | From | John Stultz <> | Date | Tue, 19 Sep 2017 20:21:29 -0700 | Subject | Re: [tip:timers/core] kselftests: timers: set-timer-lat: Tweak reporting when timer fires early |
| |
On Tue, Sep 19, 2017 at 6:02 PM, Shuah Khan <shuah@kernel.org> wrote: > Hi Greg, > > On 08/20/2017 03:56 AM, tip-bot for Greg Hackmann wrote: >> Commit-ID: a524b1184b8e86141d689fa78ad150fbf2db9b4c >> Gitweb: http://git.kernel.org/tip/a524b1184b8e86141d689fa78ad150fbf2db9b4c >> Author: Greg Hackmann <ghackmann@google.com> >> AuthorDate: Tue, 25 Jul 2017 14:36:25 -0700 >> Committer: John Stultz <john.stultz@linaro.org> >> CommitDate: Thu, 17 Aug 2017 12:14:54 -0700 >> >> kselftests: timers: set-timer-lat: Tweak reporting when timer fires early >> >> Rather than printing an error inside the alarm signal handler, set a >> flag that we check later. This keeps the test from spamming the console >> every time the alarm fires early. It also fixes the test exiting with >> error code 0 if this was the only test failure. >> >> Cc: Thomas Gleixner <tglx@linutronix.de> >> Cc: Ingo Molnar <mingo@kernel.org> >> Cc: Miroslav Lichvar <mlichvar@redhat.com> >> Cc: Richard Cochran <richardcochran@gmail.com> >> Cc: Prarit Bhargava <prarit@redhat.com> >> Cc: Stephen Boyd <stephen.boyd@linaro.org> >> Cc: Shuah Khan <shuah@kernel.org> >> Cc: linux-kselftest@vger.kernel.org >> Signed-off-by: Greg Hackmann <ghackmann@google.com> >> Signed-off-by: John Stultz <john.stultz@linaro.org> > > This commit is making the set-timer-lat hang. I reverted this commit > and there is no hang. Could you please take a look and see if this > commit should be reverted. > > make kselftest as well as make -C tools/testing/selftests/timers run_tests > hang. > > I had to revert the following as well, however a524b1184b8e86141d689fa78ad150fbf2db9b4c > is the suspect. > > Commit-ID: 28be3f8f48cfb3cf024860f042d424cd4824f5f7 > Gitweb: http://git.kernel.org/tip/28be3f8f48cfb3cf024860f042d424cd4824f5f7 > Author: Greg Hackmann <ghackmann@google.com> > AuthorDate: Tue, 25 Jul 2017 14:36:26 -0700 > Committer: John Stultz <john.stultz@linaro.org> > CommitDate: Thu, 17 Aug 2017 12:14:58 -0700 > > kselftests: timers: set-timer-lat: Add one-shot timer test cases > > Please let me know how you want to proceed. At the moment kselftest > run hangs due this test hang.
Huh. I didn't see such a hang in my testing. Let me try to reproduce and see if I can figure out whats going on.
thanks -john
| |