Messages in this thread | | | From | Dmitry Vyukov <> | Date | Tue, 19 Sep 2017 14:57:46 +0200 | Subject | Re: [PATCH 2/3] kcov: remove pointless current != NULL check |
| |
On Tue, Sep 19, 2017 at 2:46 PM, Andrey Ryabinin <aryabinin@virtuozzo.com> wrote: > __sanitizer_cov_trace_pc() is a hot code, so it's worth > to remove pointless '!current' check. Current is never NULL. > > Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
Acked-by: Dmitry Vyukov <dvyukov@google.com>
> --- > kernel/kcov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/kcov.c b/kernel/kcov.c > index 2f0e7a7c7afc..14cc8c1a7cad 100644 > --- a/kernel/kcov.c > +++ b/kernel/kcov.c > @@ -61,7 +61,7 @@ void notrace __sanitizer_cov_trace_pc(void) > * We are interested in code coverage as a function of a syscall inputs, > * so we ignore code executed in interrupts. > */ > - if (!t || !in_task()) > + if (!in_task()) > return; > mode = READ_ONCE(t->kcov_mode); > if (mode == KCOV_MODE_TRACE) { > -- > 2.13.5 >
| |