lkml.org 
[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: move sanity checking ahead of bi_front/back_seg_size updating
On Sat, Sep 16, 2017 at 07:10:30AM +0800, Jianchao Wang wrote:
> If the bio_integrity_merge_rq() return false or nr_phys_segments exceeds
> the max_segments, the merging fails, but the bi_front/back_seg_size may
> have been modified. To avoid it, move the sanity checking ahead.
>
> Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>

This looks fine to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

But can you elaborate a little more on how this found and if there
is a way to easily reproduce it, say for a blktests test case?

\
 
 \ /
  Last update: 2017-09-19 01:52    [W:0.040 / U:25.412 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site