lkml.org 
[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: linux-4.14-rc1/kernel/sysctl.c:2188: possible cut'n'paste error ?
On Mon, Sep 18, 2017 at 1:53 PM, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
> linux-4.14-rc1/kernel/sysctl.c:2188] -> [linux-4.14-rc1/kernel/sysctl.c:2190]: (warning) Identical condition '*lvalp>UINT_MAX', second condition is always false
>
> Source code is
>
> if (*lvalp > UINT_MAX)
> return -EINVAL;
> if (*lvalp > UINT_MAX)
> return -EINVAL;
>
> Suggest remove second if test.

commit 4f2fec00afa6 ("sysctl: simplify unsigned int support") removed
"negp", but missed the duplication:

-static int do_proc_douintvec_conv(bool *negp, unsigned long *lvalp,
- int *valp,
- int write, void *data)
+static int do_proc_douintvec_conv(unsigned long *lvalp,
+ unsigned int *valp,
+ int write, void *data)
{
if (write) {
- if (*negp)
+ if (*lvalp > UINT_MAX)
return -EINVAL;
if (*lvalp > UINT_MAX)
return -EINVAL;

David, do you want to send a patch?

-Kees

--
Kees Cook
Pixel Security

\
 
 \ /
  Last update: 2017-09-18 23:05    [W:0.026 / U:2.200 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site