lkml.org 
[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH RFC 6/6] Modify tag_ksz.c to support other KSZ switch drivers
Date
Sorry for the late response.

> > diff --git a/net/dsa/tag_ksz.c b/net/dsa/tag_ksz.c index 010ca0a..d5faf14
> 100644
> > --- a/net/dsa/tag_ksz.c
> > +++ b/net/dsa/tag_ksz.c
> > static struct sk_buff *ksz_xmit(struct sk_buff *skb, struct net_device
> *dev) {
> > struct dsa_slave_priv *p = netdev_priv(dev);
> > + struct dsa_switch *ds = p->dp->ds;
> > + struct ksz_device *swdev = ds->priv;
> > struct sk_buff *nskb;
> > + int len;
> > int padlen;
> > - u8 *tag;
> >
> > padlen = (skb->len >= ETH_ZLEN) ? 0 : ETH_ZLEN - skb->len;
> >
> > - if (skb_tailroom(skb) >= padlen + KSZ_INGRESS_TAG_LEN) {
> > + len = swdev->dev_ops->get_tx_len(swdev);
>
> This is ugly. We have a clean separation between a switch driver and a
> tag driver. Here you are mixing them together. Don't. Look at the
> mailing lists for what Florian and I suggested to Pavel. It will also
> solve your include file issue above.

It seems to me all tag_*.c are hard-coded. They do not have access to
the switch device and just use the bit definitions defined in the top to
do the job.

This creates a problem for all KSZ switch devices as they have different
tail tag formats and lengths. There will be potentially 4 additional
DSA_TAG_PROT_KSZ* just to handle them. Extra files will be added
with about the same code.

The KSZ9477 driver has its own problem as the tail tag length is dynamic
and not fixed. Right now the function feature that affects this behavior is
not turned on and so the problem does not happen.

But the most important thing is how do we support the offload_fwd_mark
bit in skb when the only place that has access to skb does not have access to
the switch hardware? I thought this bit is important for the new switchdev model.

A little out-of-topic is the MAC driver may have problem receiving the frame if
the tail tag length is too big. Most of the MAC drivers have big enough receive
buffer or require 64-bytes multiple so there are extra room to accommodate
the big tail tag at the end of the frame. Still some MAC drivers use exactly 1500
MTU and some additional length and may run into this problem. Currently the
Atmel Cadence MAC driver has this potential problem when certain conditions
are met.

\
 
 \ /
  Last update: 2017-09-18 21:38    [W:0.047 / U:13.804 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site