lkml.org 
[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/2] rapidio: Two fixes for 'rio_dma_transfer()'
Hey,

I don't have any relation to the rapidio code short of making a small
change to an API it used. But I reviewed both patches and they look
correct to me.

Reviewed-by: Logan Gunthorpe <logang@deltatee.com>

Logan

On 17/09/17 04:33 PM, Christophe JAILLET wrote:
> These 2 patches are really close and are both related to error handling
> in 'rio_dma_transfer()'.
> The first one fixes some resources leak in case of error.
> The 2nd one fixes a test so that the corresponding error can be handled
> correctly.
>
> I've splitted this into 2 paches because the first one looks trivial to me.
> But the 2nd one should require more attention, IMO. The existing error
> handling was dead code because 'dma_map_sg()' can not return -EFAULT. So
> this error handling code has never been executed/tested and I can't test it
> myself.
>
> Christophe JAILLET (2):
> rapidio: Fix resources leak in error handling path in
> 'rio_dma_transfer()'
> rapidio: Fix an error handling in 'rio_dma_transfer()'
>
> drivers/rapidio/devices/rio_mport_cdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>

\
 
 \ /
  Last update: 2017-09-18 18:05    [W:0.046 / U:0.700 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site