Messages in this thread | | | Date | Mon, 18 Sep 2017 16:22:40 +0200 | From | Heiko Carstens <> | Subject | Re: [PATCH v2] s390/char: Fix cdev_add usage |
| |
On Mon, Sep 18, 2017 at 11:13:13AM +0200, Jean Delvare wrote: > Function cdev_add does set cdev->dev, so there is no point in setting > it prior to calling this function. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > --- > Untested. Changes since v1 (2016-07-13): > * Improved description > * Added a few blank lines to make the code more readable > > drivers/s390/char/tape_class.c | 3 +-- > drivers/s390/char/vmlogrdr.c | 4 ++-- > drivers/s390/char/vmur.c | 4 ++-- > 3 files changed, 5 insertions(+), 6 deletions(-)
Applied, however without the extra blank lines ;) Thanks!
| |