lkml.org 
[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c
On Mon, Sep 11, 2017 at 11:00:13AM +0200, srinivas.kandagatla@linaro.org wrote:
> From: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> These two functions are defined in .c file, but called just once
> (at least for now). So, the compiler will fold them into their
> callers even without the "inline" markers.
>
> However, this kind of optimization should not be done by hand.
> It is compiler's judge after all.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/nvmem/core.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)

This isn't really a bugfix, so should wait for 4.15-rc1.

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-09-18 16:10    [W:0.060 / U:9.820 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site