[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/1] acpi: unbreak ACPI_HANDLE(), encapsulate fwnode_operations
Hi John,

On Fri, Sep 15, 2017 at 05:35:27PM -0700, wrote:
> From: John Hubbard <>
> Due to commit db3e50f3234b ("device property: Get rid of struct
> fwnode_handle type field"), ACPI_HANDLE() inadvertently became
> a GPL-only call. The call path that led to that was:
> to_acpi_device_node()
> is_acpi_device_node()
> acpi_device_fwnode_ops
> DECLARE_ACPI_FWNODE_OPS(acpi_device_fwnode_ops);
> ...and the new DECLARE_ACPI_FWNODE_OPS() includes
> EXPORT_SYMBOL_GPL, whereas previously it was a static struct.
> In order to avoid changing any of that, let's instead provide ever
> so slightly better encapsulation of those struct fwnode_operations
> instances. Those do not really need to be directly used in
> inline function calls in header files. Simply moving two small
> functions (is_acpi_device_node and is_acpi_data_node) out of
> acpi_bus.h, and into a .c file, does that.
> That leaves the internals of struct fwnode_operations as GPL-only
> (which I think was the intent all along), but un-breaks any driver
> code out there that relies on the ACPI subsystem's being (historically)
> an EXPORT_SYMBOL-usable system. By that, I mean, ACPI_HANDLE() and
> other basic ACPI calls were non-GPL-protected.

Works for me.

Acked-by: Sakari Ailus <>

OF appears to have the same effective change; Rob: let me know if you'd
like me to send a patch for that, or whether this is preferred. On OF both
appear to be used (EXPORT_SYMBOL / EXPORT_SYMBOL_GPL).


Sakari Ailus

 \ /
  Last update: 2017-09-18 12:51    [W:0.062 / U:1.572 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site