lkml.org 
[lkml]   [2017]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 4.13 14/52] thunderbolt: Remove superfluous check
Date
4.13-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Bernat, Yehezkel <yehezkel.bernat@intel.com>

commit 8fdd6ab36197ad891233572c57781b1f537da0ac upstream.

The key size is tested by hex2bin() already (as '\0' isn't an hex digit)

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
drivers/thunderbolt/switch.c | 3 ---
1 file changed, 3 deletions(-)

--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -808,9 +808,6 @@ static ssize_t key_store(struct device *
u8 key[TB_SWITCH_KEY_SIZE];
ssize_t ret = count;

- if (count < 64)
- return -EINVAL;
-
if (hex2bin(key, buf, sizeof(key)))
return -EINVAL;


\
 
 \ /
  Last update: 2017-09-18 11:58    [W:0.261 / U:0.468 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site