lkml.org 
[lkml]   [2017]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] dmaengine: edma: Reject slave configs using a buswidth of 8 and larger
Date
The driver would happily accept buswidth of 16/32/64 bytes and program
garbage to its registers.

Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
---
drivers/dma/edma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 3879f80a4815..c944ea339425 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -887,8 +887,8 @@ static int edma_slave_config(struct dma_chan *chan,
{
struct edma_chan *echan = to_edma_chan(chan);

- if (cfg->src_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES ||
- cfg->dst_addr_width == DMA_SLAVE_BUSWIDTH_8_BYTES)
+ if (cfg->src_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES ||
+ cfg->dst_addr_width >= DMA_SLAVE_BUSWIDTH_8_BYTES)
return -EINVAL;

memcpy(&echan->cfg, cfg, sizeof(echan->cfg));
--
2.14.1
\
 
 \ /
  Last update: 2017-09-17 16:25    [W:0.042 / U:3.884 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site