lkml.org 
[lkml]   [2017]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] checkpatch: do not check missing blank line before builtin_*_driver
Hi Joe,

2017-09-18 5:44 GMT+09:00 Joe Perches <joe@perches.com>:
> On Sun, 2017-09-17 at 23:59 +0900, Masahiro Yamada wrote:
>> checkpatch.pl does not check missing blank line before module_*_driver.
>> I want it to behave likewise for builtin_*_driver.
> []
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index dd2c262aebbf..cec896306619 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -3103,6 +3103,7 @@ sub process {
>> $line =~ /^\+[a-z_]*init/ ||
>> $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
>> $line =~ /^\+\s*DECLARE/ ||
>> + $line =~ /^\+\s*builtin_/ ||
>
> I believe
>
> $line =~ /^\+\s*builtin_[\w_]*driver/ ||
>
> would be better


Thanks for your advice.
I've sent v2.


--
Best Regards
Masahiro Yamada

\
 
 \ /
  Last update: 2017-09-18 04:04    [W:0.041 / U:3.676 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site