lkml.org 
[lkml]   [2017]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi
Hi Rob,

Thanks for your reply.

On 09/14/2017 01:24 AM, Rob Herring wrote:
> On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt
>> index 929ca6756b02..841a1159e234 100644
>> --- a/Documentation/devicetree/bindings/sound/rt5514.txt
>> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt
>> @@ -4,7 +4,7 @@ This device supports I2C only.
>
> SPI support should be added to this document.
ok, will do.
>
>>
>> Required properties:
>>
>> -- compatible : "realtek,rt5514".
>> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c".
>
> There's no need for the -spi or -i2c compatibles. This is implied by
> being a child of those controllers.
heiko mentioned i should add it in the binding in:
https://patchwork.kernel.org/patch/9918987/

\
 
 \ /
  Last update: 2017-09-18 03:23    [W:0.050 / U:6.264 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site