lkml.org 
[lkml]   [2017]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 2/2] [media] it913x: Improve three size determinations
From
Date
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 16 Sep 2017 20:06:01 +0200

Replace the specification of data structures by variable references
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/tuners/it913x.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/media/tuners/it913x.c b/drivers/media/tuners/it913x.c
index 6af9507823fa..149f36d5e503 100644
--- a/drivers/media/tuners/it913x.c
+++ b/drivers/media/tuners/it913x.c
@@ -393,5 +393,5 @@ static int it913x_probe(struct platform_device *pdev)
const struct platform_device_id *id = platform_get_device_id(pdev);
char *chip_ver_str;

- dev = kzalloc(sizeof(struct it913x_dev), GFP_KERNEL);
+ dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (!dev)
@@ -404,8 +404,7 @@ static int it913x_probe(struct platform_device *pdev)
dev->role = pdata->role;

fe->tuner_priv = dev;
- memcpy(&fe->ops.tuner_ops, &it913x_tuner_ops,
- sizeof(struct dvb_tuner_ops));
+ memcpy(&fe->ops.tuner_ops, &it913x_tuner_ops, sizeof(it913x_tuner_ops));
platform_set_drvdata(pdev, dev);

if (dev->chip_ver == 1)
@@ -427,8 +426,7 @@ static int it913x_remove(struct platform_device *pdev)
struct dvb_frontend *fe = dev->fe;

dev_dbg(&pdev->dev, "\n");
-
- memset(&fe->ops.tuner_ops, 0, sizeof(struct dvb_tuner_ops));
+ memset(&fe->ops.tuner_ops, 0, sizeof(it913x_tuner_ops));
fe->tuner_priv = NULL;
kfree(dev);

--
2.14.1
\
 
 \ /
  Last update: 2017-09-16 20:34    [W:0.199 / U:0.060 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site